developers-list Digest, Vol 4, Issue 12

[developers-list-request-d/]

This message was forwarded from developers-list-d/***@public.gmane.org The MonetDB
mailing lists have moved to monetdb.org. Please subscribe to
developers-list-d/***@public.gmane.org, and unsubscribe from this list.
See: http://mail.monetdb.org/mailman/listinfo/developers-list

Send developers-list mailing list submissions to
developers-list-d/***@public.gmane.org

To subscribe or unsubscribe via the World Wide Web, visit
http://mail.monetdb.org/mailman/listinfo/developers-list
or, via email, send a message with subject or body 'help' to
developers-list-request-d/***@public.gmane.org

You can reach the person managing the list at
developers-list-owner-d/***@public.gmane.org

When replying, please edit your Subject line so it is more specific
than "Re: Contents of developers-list digest..."


Today's Topics:

1. Re: MonetDB: default - fixed a low level bug where empty mapi
result... (Sjoerd Mullender)
2. Re: MonetDB: default - fixed a low level bug where empty mapi
result... (Gijs Molenaar)


----------------------------------------------------------------------

Message: 1
Date: Fri, 14 Dec 2012 14:35:32 +0100
From: Sjoerd Mullender <sjoerd-d/***@public.gmane.org>
To: developers-list-d/***@public.gmane.org
Subject: Re: MonetDB: default - fixed a low level bug where empty mapi
result...
Message-ID: <50CB2B24.80905-d/***@public.gmane.org>
Content-Type: text/plain; charset=UTF-8

Changeset: 81f191d61822 for MonetDB
URL: http://dev.monetdb.org/hg/MonetDB?cmd=changeset;node=81f191d61822
clients/python2/monetdb/mapi.py
clients/python3/monetdb/mapi.py
Branch: default
fixed a low level bug where empty mapi results where not properly handled

Is this is fix that should have gone to the Oct2012 branch?
Please, make sure you fix bugs in the lowest branch where the bug occurs
and that is still maintained. Currently the still maintained branches
are Oct2012, Feb2013 and default.

diff --git a/clients/python2/monetdb/mapi.py b/clients/python2/monetdb/mapi.py
--- a/clients/python2/monetdb/mapi.py
+++ b/clients/python2/monetdb/mapi.py
self.__putblock(operation)
response = self.__getblock()
- return True
+ return ""
- return response[3:].strip() or True
+ return response[3:].strip() or ""

Isn't this equivalent to:
return response[3:].strip()

# tell server it isn't going to get more
return self.cmd("")
diff --git a/clients/python3/monetdb/mapi.py b/clients/python3/monetdb/mapi.py
--- a/clients/python3/monetdb/mapi.py
+++ b/clients/python3/monetdb/mapi.py
self.__putblock(operation)
response = self.__getblock()
- return True
+ return ""
- return response[3:].strip() or True
+ return response[3:].strip() or ""
# tell server it isn't going to get more
return self.cmd("")
_______________________________________________
checkin-list mailing list
http://mail.monetdb.org/mailman/listinfo/checkin-list

--
Sjoerd Mullender


------------------------------

Message: 2
Date: Fri, 14 Dec 2012 15:05:12 +0100
From: Gijs Molenaar <g.j.molenaar-V/Xpf/***@public.gmane.org>
To: "Communication channel for developers of the MonetDB suite."
<developers-list-d/***@public.gmane.org>
Subject: Re: MonetDB: default - fixed a low level bug where empty mapi
result...
Message-ID: <50CB3218.3070108-V/Xpf/***@public.gmane.org>
Content-Type: text/plain; charset="iso-8859-1"

Changeset: 81f191d61822 for MonetDB
URL: http://dev.monetdb.org/hg/MonetDB?cmd=changeset;node=81f191d61822
clients/python2/monetdb/mapi.py
clients/python3/monetdb/mapi.py
Branch: default
fixed a low level bug where empty mapi results where not properly handled

Is this is fix that should have gone to the Oct2012 branch?

Probably yes.

Please, make sure you fix bugs in the lowest branch where the bug occurs
and that is still maintained. Currently the still maintained branches
are Oct2012, Feb2013 and default.

I just discovered this issue and I didn't had the time anymore
to merge it into the other branches. I'm not able to do merge them anymore
today due to time constrains, sorry.



-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 261 bytes
Desc: OpenPGP digital signature
URL: <http://mail.monetdb.org/pipermail/developers-list/attachments/20121214/faa037a0/attachment.sig>

------------------------------

_______________________________________________
developers-list mailing list
developers-list-d/***@public.gmane.org
http://mail.monetdb.org/mailman/listinfo/developers-list


End of developers-list Digest, Vol 4, Issue 12
**********************************************